Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mismatches in message fields between specs & implementation #84

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix mismatches in message fields between specs & implementation #84

wants to merge 1 commit into from

Conversation

pythcoiner
Copy link
Contributor

This PR unify the messages fields name between specs & implementation.

In SetCustomMiningJob:

  • mining_job_token -> token
  • coinbase_tx_input_nSequence -> coinbase_tx_input_n_sequence

In AllocateMiningJobToken.Success:

  • coinbase_tx_outputs -> coinbase_output

In DeclareMiningJob:

  • coinbase_tx_prefix -> coinbase_prefix
  • coinbase_tx_suffix -> coinbase_suffix

In SubmitSolution the field version was not defined

In SetNewPrevHash:

  • nBits -> n_bits

I've kept the actual implementation naming in order to not create breaking changes on messages struct signature.

GitGab19
GitGab19 reviewed Jun 28, 2024
View reviewed changes
Copy link
Collaborator

@GitGab19 GitGab19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not simply fixing names in our implementation?
I wouldn't change specs in this case tbh

@rrybarczyk rrybarczyk assigned rrybarczyk and unassigned rrybarczyk Jul 9, 2024
@pythcoiner
Copy link
Contributor Author

Why not simply fixing names in our implementation? I wouldn't change specs in this case tbh

i've first try to avoid breaking changes, but yeah it more clean on a long term POV

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GitGab19 GitGab19 GitGab19 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pythcoiner @GitGab19 @rrybarczyk